-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActivateJobsCommand updated to set tenantIds. #594
Merged
ChrisKujawa
merged 9 commits into
camunda-community-hub:main
from
ShawnAbshire:sabshire-multi-tenancy-activatejobs
Feb 1, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
506a575
feat(multitenancy): ActivateJobsCommand updated to set tenantIds.
ShawnAbshire 4eafab4
refactor(multitenancy): Move ITenantIdsCommandStep to before final step.
ShawnAbshire d594989
feat(multitenancy): Reword ITenantIdsCommandStep method summaries.
ShawnAbshire f759a0d
docs: enhnace method doc
ChrisKujawa 42f4cd7
docs: enhnace method doc
ChrisKujawa 84f6880
docs: enhnace method doc
ChrisKujawa f78e3c6
docs: enhnace method doc
ChrisKujawa ee7da1c
docs: enhance method doc
ChrisKujawa 8ffaa88
docs: enhance method doc
ChrisKujawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
using System.Collections.Generic; | ||
|
||
namespace Zeebe.Client.Api.Commands | ||
{ | ||
public interface ITenantIdsCommandStep<out T> | ||
{ | ||
/// <summary> | ||
/// Specifies the tenants that may own any entities (e.g. process definition, process instances, etc.) resulting from this command. | ||
/// </summary> | ||
ChrisKujawa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// | ||
/// This can be useful when requesting jobs for multiple tenants at once. Each of the activated | ||
/// jobs will be owned by the tenant that owns the corresponding process instance. | ||
/// <param name="tenantIds">the identifiers of the tenants to specify for this command, e.g. ["ACME", "OTHER"]</param> | ||
/// <returns>The builder for this command. Call <see cref="IFinalCommandStep{T}.Send"/> to complete the command and send it | ||
/// to the broker.</returns> | ||
T TenantIds(IList<string> tenantIds); | ||
|
||
/// <summary> | ||
/// Specifies the tenants that may own any entities (e.g. process definition, process instances, etc.) resulting from this command. | ||
/// </summary> | ||
ChrisKujawa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/// | ||
/// This can be useful when requesting jobs for multiple tenants at once. Each of the activated | ||
/// jobs will be owned by the tenant that owns the corresponding process instance. | ||
/// <param name="tenantIds">the identifiers of the tenants to specify for this command, e.g. ["ACME", "OTHER"]</param> | ||
/// <returns>The builder for this command. Call <see cref="IFinalCommandStep{T}.Send"/> to complete the command and send it | ||
/// to the broker.</returns> | ||
T TenantIds(params string[] tenantIds); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 We could either add here a single AddTenant or extend the previous introduced interface