Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad audience in camunda cloud channel factory, clean parameters in camunda cloud channel factory #511

Closed
wants to merge 2 commits into from

Conversation

dimastbk
Copy link
Collaborator

@dimastbk dimastbk commented Oct 9, 2024

fix #510

I suggest allowing only the required options to be set, like in the Java SDK
image

ping @felicijus

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11277692278

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.927%

Totals Coverage Status
Change from base Build 11277676454: 0.005%
Covered Lines: 1104
Relevant Lines: 1139

💛 - Coveralls

@dimastbk dimastbk changed the title fix: issue510, remove unused parameters from camunda cloud func fix: bad audience in camunda cloud channel factory, clean parameters in camunda cloud channel factory Oct 9, 2024
@felicijus
Copy link
Contributor

If i remember correctly Spring Boot SDK for Zeebe sets these parameters by default too.
@dimastbk

@dimastbk
Copy link
Collaborator Author

dimastbk commented Oct 9, 2024

Spring Boot SDK calculates audience, scope isn't required by Camunda Cloud and oauth url is static

@dimastbk
Copy link
Collaborator Author

dimastbk commented Oct 9, 2024

I tested this changes with Camunda SaaS

@felicijus
Copy link
Contributor

Can I check myself tomorrow, currently i only got my phone?

@felicijus
Copy link
Contributor

  1. audience should be static Camunda Docs
    audience="zeebe.camunda.io
  2. scope should either be None (Optional parameter), because setting it to the cluster_id also works. Maybe relevant for enterprise user with custom scope configs...
  3. leeway and expire_in i don't really know if there is need for customization. Would not hurt to keep I guess.

#510 Is an import error, where the old create_camunda_cloud_channel function was used. (The old function also needs a static audience)

Do we want to close this pull-request then and I will provide a fix for the scope issue ?

@dimastbk dimastbk closed this Oct 10, 2024
@dimastbk dimastbk deleted the issue510 branch October 10, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0rc6 and rc7 generate connection errors
3 participants