Pass all variables to task when TaskConfig.variables_to_fetch==[]
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PunchyRascal
force-pushed
the
task_all_params_fix
branch
from
d68a5cb to
299d9fc
Compare
PunchyRascal
changed the title
PunchyRascal
changed the title
TaskConfig.variables_to_fetch==[]
|
Hi. Please, rebase your PR |
Because empty list in variables_to_fetch results in all variables being fetched from Zeebe and it is reasonably expected that they will also be passed to the task + use nonlocal variables instead of instance properties in tests to avoid potential conflicts between tests
PunchyRascal
force-pushed
the
task_all_params_fix
branch
from
299d9fc to
e3a88da
Compare
dimastbk
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass all variables to task when
TaskConfig.variables_to_fetch==[]Because empty list in
TaskConfig.variables_to_fetchresults in all variables being fetched from Zeebe and it is reasonably expected that they will also be passed to the task.+ use nonlocal variables instead of instance properties in tests to avoid potential conflicts between tests
Changes
API Updates
New Features (required)
It is now possible to use
*args, **kwargsin task and receive all variables there.Deprecations (required)
N/A
Enhancements (optional)
N/A
Checklist
References
Broken in commit related to #404