Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get_channel_options from dict to tuple #483

Conversation

felicijus
Copy link
Contributor

@felicijus felicijus commented Sep 18, 2024

Change grpc options (channel_arguments) from dict to tuple

Changes

  • get_channel_options type from dict[str, Any] -> ChannelArgumentType = Sequence[Tuple[str, Any]]
  • dependend channel creation methods

API Updates

New Features (required)

The function for defining default grpc channel_arguments

Deprecations (required)

Enhancements (optional)

When changing between librarys users can define the channel options like in the official grpc package itself.
See https://grpc.github.io/grpc/python/glossary.html.

Checklist

  • Unit tests
  • Documentation

References

https://grpc.github.io/grpc/python/glossary.html
https://github.com/grpc/grpc/blob/v1.64.x/include/grpc/impl/channel_arg_names.h

Resolves #482

@felicijus felicijus marked this pull request as ready for review September 18, 2024 21:42
@felicijus
Copy link
Contributor Author

I found something that could be a Problem.

"c:\Users\A113927430\github\pyzeebe\pyzeebe\types.py" is overriding the stdlib module "types"Pylance[reportShadowedImports](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportShadowedImports)

@dimastbk dimastbk merged commit f163708 into camunda-community-hub:master Sep 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change grpc options (channel_arguments) from dict to tuple
2 participants