Bugfix/all variables injected when function has no variables #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bugfix/all-variables-injected-when-function-has-no-variables
|
|
|
Looks good, but please add a simple unit test so that this bug doesn't reproduce. |
Done. |
JonatanMartens
requested changes
Feb 21, 2024
pyzeebe/worker/task_router.py
Outdated
| @@ -71,7 +72,7 @@ def task( | |||
| def task_wrapper(task_function: Callable): | |||
| config = TaskConfig( | |||
| task_type, | |||
| exception_handler, | |||
| exception_handler or self._default_exception_handler, | |||
There was a problem hiding this comment.
Would be nice to add a small unit test for this
tests/unit/utils/random_utils.py
Outdated
| def _build_dict_from_list(keys: List[str], *values): | ||
| if not values: | ||
| return dict(zip(keys, keys)) | ||
| assert len(keys) == len(values) |
There was a problem hiding this comment.
No need to add this imo
Co-authored-by: Jonatan Martens <[email protected]>
…n-has-no-variables
|
Waiting for re-review :) |
ohasi
commented
Feb 25, 2024
tests/unit/utils/random_utils.py
Outdated
| def _build_dict_from_list(keys: List[str], *values): | ||
| if not values: | ||
| return dict(zip(keys, keys)) | ||
| assert len(keys) == len(values) |
pyzeebe/worker/task_router.py
Outdated
| @@ -71,7 +72,7 @@ def task( | |||
| def task_wrapper(task_function: Callable): | |||
| config = TaskConfig( | |||
| task_type, | |||
| exception_handler, | |||
| exception_handler or self._default_exception_handler, | |||
|
fixed in #404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where function decorated as task receives all variables that are available to the task causing an
unexpected keyword argumenterror. Referenced in #337.The bug originates from the zeebe grpc API for
ActivateJobs. If no variables are passed tofetchVariable, it fetches all available variables.Changes
include_variablesflag to private function_create_job_from_raw_job. If flag is set to False, retrieved variables will be ignored.The function is called in one place, which now calls it with
bool(variables_to_fetch)as the flag's value.Noneor an empty list will cause no variables to be injected to theJobobject, so they will never end up getting passed to the function.API Updates
New Features (required)
Checklist
References
ActivateJobs API
Fixes #337