Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/54 Google Cloud inclusive properties-local.mk #55

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

anderskristian
Copy link

@anderskristian anderskristian commented May 22, 2023

This PR contains

  1. gcloud container clusters get-credentials before using kubectl.
  2. introducing properties-local.mk
  3. The properties-local.mk is "empty" with check that "project" and "region" are defined by the developer.
  4. README.md shows sequence of make steps.

@upgradingdave
Copy link
Collaborator

Thanks for this @anderskristian!

I'll review this as soon as I have some time (hopefully later this week) 💪

@upgradingdave
Copy link
Collaborator

@falko - Can you review this when you have a chance?

This moves custom configurations (such as custom region, machine type, cluster name, dns name, etc) into .mk files inside a config directory.

Please let me know what you think? If you give the 👍 , then I'll refactor azure and aws to match.

@upgradingdave
Copy link
Collaborator

Refactored aws tls profile to use config directory.

Still need to refactore other aws profiles as well as azure profiles.

Anders K. Andersen added 2 commits August 16, 2023 10:32
It makes customer merge conflicts less.
It makes modularity / refactoring "easier"
@anderskristian
Copy link
Author

anderskristian commented Aug 16, 2023

I have added .ignore file + improved the Google README.md file with a "sub menu"
I really like the standardisation that @upgradingdave added above.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ upgradingdave
❌ Anders K. Andersen


Anders K. Andersen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants