Payment example process application: migrated to sdk #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
reviewed
Oct 30, 2024
There was a problem hiding this comment.
@jonathanlukas looks good. 👍 I have a few minor comments. Please have a look. 🍪
❌ We should also update the README of the project.
🔧 Maybe, we need to update the application.properties as well. See the note in the docs.
Comment on lines
+36
to
+40
| <dependency> | ||
| <groupId>io.camunda</groupId> | ||
| <artifactId>zeebe-process-test-extension-testcontainer</artifactId> | ||
| <version>${zeebe.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
🔧 We could use the new Camunda Process Test instead of ZPT. It works natively with the Spring SDK. It is in an early stage but should support most of the assertions used in the test.
| value: http://camunda-platform-keycloak.camunda-platform.svc.cluster.local/auth/realms/camunda-platform/protocol/openid-connect/token | ||
| - name: ZEEBE_TOKEN_AUDIENCE | ||
| - name: CAMUNDA_CLIENT_AUTH_AUDIENCE |
There was a problem hiding this comment.
❌ The property name is wrong (ref).
Suggested change
| - name: CAMUNDA_CLIENT_AUTH_AUDIENCE | |
| - name: CAMUNDA_CLIENT_ZEEBE_AUDIENCE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates our payment example process application to the sdk
Additional context
Types of changes
Checklist:
.github/workflows/build.yaml