-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PR description follows a template when potential breaking changes are made #1351
Merged
taylanisikdemir
merged 2 commits into
cadence-workflow:master
from
taylanisikdemir:taylan/breaking_change_warn
Jul 2, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
**Detailed Description** | ||
[In-depth description of the changes made to the interfaces, specifying new fields, removed fields, or modified data structures] | ||
|
||
**Impact Analysis** | ||
- **Backward Compatibility**: [Analysis of backward compatibility] | ||
- **Forward Compatibility**: [Analysis of forward compatibility] | ||
|
||
**Testing Plan** | ||
- **Unit Tests**: [Do we have unit test covering the change?] | ||
- **Persistence Tests**: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?] | ||
- **Integration Tests**: [Do we have integration test covering the change?] | ||
- **Compatibility Tests**: [Have we done tests to test the backward and forward compatibility?] | ||
|
||
**Rollout Plan** | ||
- What is the rollout plan? | ||
- Does the order of deployment matter? | ||
- Is it safe to rollback? Does the order of rollback matter? | ||
- Is there a kill switch to mitigate the impact immediately? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
name: Workflow for Breaking Change Reminder | ||
on: | ||
pull_request: | ||
paths: | ||
# below files do not cover all the exposed types/funcs, but it's a good start to detect potentially breaking changes | ||
- activity/activity.go | ||
- client/client.go | ||
- encoded/encoded.go | ||
- interceptors/workflow_interceptor.go | ||
- internal/activity.go | ||
- internal/client.go | ||
- internal/encoded.go | ||
- internal/workflow.go | ||
- internal/interceptors.go | ||
- internal/worker.go | ||
- internal/workflow.go | ||
- worker/worker.go | ||
- workflow/*.go | ||
|
||
jobs: | ||
breaking-change-pr-template-reminder: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Fail if PR description is missing breaking change template | ||
if: steps.pr-changes.outputs.changes != '[]' | ||
run: | | ||
PR_NUMBER=${{ github.event.pull_request.number }} | ||
PR_URL="https://api.github.com/repos/${{ github.repository }}/pulls/${PR_NUMBER}" | ||
BODY=$(curl $PR_URL | jq '.body') | ||
CHECKLIST=( | ||
"Detailed Description" | ||
"Impact Analysis" | ||
"Testing Plan" | ||
"Rollout Plan" | ||
) | ||
TEMPLATE=$(cat .github/workflows/breaking_change_pr_template.md) | ||
|
||
for i in "${CHECKLIST[@]}"; do | ||
if [[ "$BODY" == *"$i"* ]]; then | ||
continue | ||
else | ||
echo "Potential breaking changes detected! Please update the PR description to include following template:" | ||
echo "---" | ||
echo "$TEMPLATE" | ||
echo "---" | ||
exit 1 | ||
fi | ||
done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Groxx I guess you have some ideas on this template. Merging it now. Feel free to update