Ensure PR description follows a template when potential breaking changes are made #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx and
demirkayaender
as code owners
demirkayaender
approved these changes
Jul 2, 2024
taylanisikdemir
commented
Jul 2, 2024
| @@ -0,0 +1,18 @@ | |||
| **Detailed Description** | |||
There was a problem hiding this comment.
@Groxx I guess you have some ideas on this template. Merging it now. Feel free to update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a new github workflow to run on schema changes and fails if the PR template is missing critical information.
Why?
To warn the developer about potential breaking changes.
How did you test it?
Made some changes on activity.go and validated the workflow is failing as expected when PR description is missing required sections.