-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to wasm-opt-rs crate #604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering: did you notice any performance improvements or regressions with this change? I'm assuming there shouldn't be anything significant, but it might be interesting to run some benchmarks to be certain. I'm assuming fuel-wise nothing significant changed, given that the fuel tests didn't fail.
Looks like performance either hasn't changed materially or has slightly improved. Here are the results from
|
Description of the change
Switches from using
binaryen-rs
towasm-opt
crate to applywasm-opt
optimizations.Why am I making this change?
Closes #315 which should address #594 and #397. The latest commit for
binaryen-sys
does not build on modern Linux distributions. Switching to a different dependency with a more up-to-date version ofwasm-opt
should allow Javy CLI to compile on modern Linux distributions.Checklist
javy-cli
andjavy-core
do not require updating CHANGELOG files.