Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javy-cli build fails while building binaryen-sys with gcc 13 #397

Closed
oroppas opened this issue Jun 14, 2023 · 1 comment
Closed

javy-cli build fails while building binaryen-sys with gcc 13 #397

oroppas opened this issue Jun 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@oroppas
Copy link

oroppas commented Jun 14, 2023

Operating system: Linux (Arch Linux)
Processor architecture: x86_64
Rust version: 1.70.0
Javy version: main branch

Problem

cargo build -p javy-cli -r fails while building binaryen-sys with gcc 13.1.1 due to
missing # include <cstdin> as addressed in WebAssembly/binaryen#5458.

Error Message and Context

    Finished release [optimized] target(s) in 0.33s
   Compiling binaryen-sys v0.12.1 (https://github.com/pepyakin/binaryen-rs?rev=00c98174843f957681ba0bc5cdcc9d15f5d0cb23#00c98174)
error: failed to run custom build command for `binaryen-sys v0.12.1 (https://github.com/pepyakin/binaryen-rs?rev=00c98174843f957681ba0bc5cdcc9d15f5d0cb23#00c98174)`

Caused by:
  process didn't exit successfully: `/home/ryutas/packages/wasm/javy/javy/target/release/build/binaryen-sys-306852bc4409cd61/build-script-build` (exit status: 101)
  --- stdout
  CMAKE_TOOLCHAIN_FILE_x86_64-unknown-linux-gnu = None
  CMAKE_TOOLCHAIN_FILE_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_x86_64-unknown-linux-gnu = None
  CMAKE_GENERATOR_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_x86_64-unknown-linux-gnu = None
  CMAKE_PREFIX_PATH_x86_64_unknown_linux_gnu = None
  HOST_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_x86_64-unknown-linux-gnu = None
  CMAKE_x86_64_unknown_linux_gnu = None
  HOST_CMAKE = None
  CMAKE = None
  running: cd "/home/ryutas/packages/wasm/javy/javy/target/release/build/binaryen-sys-5abace4d675441a0/out/build" && CMAKE_PREFIX_PATH="" "cmake" "/home/ryutas/.cargo/git/checkouts/binaryen-rs-2ef43ee92a3c1c21/00c9817/binaryen-sys/binaryen" "-DBUILD_STATIC_LIB=ON" "-DENABLE_WERROR=OFF" "-DCMAKE_INSTALL_PREFIX=/home/ryutas/packages/wasm/javy/javy/target/release/build/binaryen-sys-5abace4d675441a0/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/sbin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/sbin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_ASM_COMPILER=/usr/sbin/cc" "-DCMAKE_BUILD_TYPE=Release"
  -- Building with -DBUILD_LLVM_DWARF
  -- Building with -Wall
  -- Building with -Wextra
  -- Building with -Wno-unused-parameter
  -- Building with -fno-omit-frame-pointer
  -- Building with -fno-rtti
  -- Building with -Wno-implicit-int-float-conversion
  -- Building with -Wno-unknown-warning-option
  -- Building with -Wswitch
  -- Building with -Wimplicit-fallthrough
  -- Building with -Wnon-virtual-dtor
  -- Building with -fPIC
  -- Building with -O2
  -- Building with -UNDEBUG
  -- Building libbinaryen as statically linked library.
  -- Configuring done (0.2s)
  -- Generating done (0.1s)
  -- Build files have been written to: /home/ryutas/packages/wasm/javy/javy/target/release/build/binaryen-sys-5abace4d675441a0/out/build
  running: cd "/home/ryutas/packages/wasm/javy/javy/target/release/build/binaryen-sys-5abace4d675441a0/out/build" && MAKEFLAGS="-j --jobserver-fds=19,20 --jobserver-auth=19,20" "cmake" "--build" "." "--target" "install" "--config" "Release" "--parallel" "12"
  [  3%] Built target emscripten-optimizer
  [  1%] Built target cfg
  [  2%] Built target asmjs
  [  4%] Built target gtest_main
  [  4%] Built target gtest
  [  8%] Built target support
  [ 15%] Built target ir
  [ 15%] Building CXX object src/wasm/CMakeFiles/wasm.dir/wat-lexer.cpp.o
  [ 41%] Built target llvm_dwarf
  [ 79%] Built target passes

  --- stderr
  fatal: No names found, cannot describe anything.
  CMake Warning at CMakeLists.txt:54 (message):
    Error running git describe to determine version


  make: warning: -j12 forced in submake: resetting jobserver mode.
  In file included from /home/ryutas/.cargo/git/checkouts/binaryen-rs-2ef43ee92a3c1c21/00c9817/binaryen-sys/binaryen/src/wasm/wat-lexer.cpp:25:
  /home/ryutas/.cargo/git/checkouts/binaryen-rs-2ef43ee92a3c1c21/00c9817/binaryen-sys/binaryen/src/wat-lexer.h:62:3: error: ‘uint64_t’ does not name a type
     62 |   uint64_t n;
        |   ^~~~~~~~
  /home/ryutas/.cargo/git/checkouts/binaryen-rs-2ef43ee92a3c1c21/00c9817/binaryen-sys/binaryen/src/wat-lexer.h:20:1: note: ‘uint64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
     19 | #include <iterator>
    +++ |+#include <cstdint>
     20 | #include <optional>
...
@oroppas oroppas added the bug Something isn't working label Jun 14, 2023
@jeffcharles
Copy link
Collaborator

With #604 merged, this should finally be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants