Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack removal: platform changes #335

Merged
merged 52 commits into from
Aug 1, 2023
Merged

Stack removal: platform changes #335

merged 52 commits into from
Aug 1, 2023

Conversation

natalieparellano
Copy link
Member

@natalieparellano natalieparellano commented Dec 5, 2022 •
edited
Loading

No description provided.

@natalieparellano
Removed stack and mixin from terminology, updated stack section
d38828a 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Update analyzer
a2d3554 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Format TOC, fix TODO
4531d8c 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Add derive missing values for known stack ID
58904f2 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Add guidance around SBOM and rebase
3140c7d 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Fix nesting
f31e623 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Remove language about a "contract"
c58ae52 
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
natalieparellano commented Dec 5, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Dec 5, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Dec 5, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Dec 5, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Describe how analyzed is used by the detector
cac2d6e 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Remove other references to stack
d6141f2 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Rename platform -> target
10293e9 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Small syntax change
ec8769e 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Rename architecture -> arch to match buildpack spec
0373ea9 
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Wording
941516e 
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
natalieparellano commented Dec 6, 2022
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano
Copy link
Member Author

To note: if image extensions are used to switch the run image, whatever validations were already performed will need to be re-done by the exporter. This may affect how we choose to design the API.

jabrown85
jabrown85 reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@jabrown85 jabrown85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty good about this direction - hard to tell what rough edges may exist without doing the work.

platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jan 9, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano natalieparellano linked an issue Jan 9, 2023 that may be closed by this pull request
[RFC #0096] Remove stacks from platform spec #258
Closed
natalieparellano
natalieparellano commented Jan 9, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
This was referenced Jan 9, 2023
Closed
Closed
natalieparellano
natalieparellano commented Jan 9, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jul 24, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
@natalieparellano @hone
Apply suggestions from code review
aec9203 
Co-authored-by: Terence Lee <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
@natalieparellano
Copy link
Member Author

@hone would you mind taking another pass through the open convos? I think I addressed most of the stuff. The last open question for me is around io.buildpacks.id.

@hone hone mentioned this pull request Jul 25, 2023
Open
natalieparellano
natalieparellano commented Jul 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jul 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jul 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
natalieparellano
natalieparellano commented Jul 26, 2023
View reviewed changes
platform.md Outdated Show resolved Hide resolved
dzuelke
dzuelke reviewed Jul 26, 2023
View reviewed changes
platform.md Show resolved Hide resolved
@natalieparellano natalieparellano mentioned this pull request Jul 28, 2023
Merged
@natalieparellano natalieparellano merged commit e6f047e into platform/0.12 Aug 1, 2023
@natalieparellano natalieparellano deleted the stack-removal/platform branch August 1, 2023 15:57
@natalieparellano natalieparellano mentioned this pull request Aug 1, 2023
Merged
@natalieparellano natalieparellano mentioned this pull request Oct 23, 2023
Closed
@enrichman enrichman mentioned this pull request Nov 23, 2023
Merged
@edmorley edmorley mentioned this pull request Mar 27, 2024
Closed
edmorley added a commit to edmorley/spec that referenced this pull request Mar 27, 2024
@edmorley
Correct specification for deprecated CNB_STACK_ID
551833d 
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335.

Fixes buildpacks#396.

Signed-off-by: Ed Morley <[email protected]>
@edmorley edmorley mentioned this pull request Mar 27, 2024
Merged
edmorley added a commit to edmorley/spec that referenced this pull request Mar 27, 2024
@edmorley
Correct specification for deprecated CNB_STACK_ID
3524909 
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335.

Fixes buildpacks#396.
Backport of buildpacks#397.

Signed-off-by: Ed Morley <[email protected]>
edmorley added a commit to edmorley/spec that referenced this pull request Mar 27, 2024
@edmorley
Correct specification for deprecated CNB_STACK_ID
5528250 
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335.

Fixes buildpacks#396.
Backport of buildpacks#397.

Signed-off-by: Ed Morley <[email protected]>
@edmorley edmorley mentioned this pull request Mar 27, 2024
Merged
edmorley added a commit to edmorley/spec that referenced this pull request Mar 27, 2024
@edmorley
Correct specification for deprecated CNB_STACK_ID
b0af0fe 
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335.

Fixes buildpacks#396.
Backport of buildpacks#397.

Signed-off-by: Ed Morley <[email protected]>
edmorley added a commit to edmorley/spec that referenced this pull request Mar 27, 2024
@edmorley
Correct specification for deprecated CNB_STACK_ID
86a20a3 
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335.

Fixes buildpacks#396.
Backport of buildpacks#397.

Signed-off-by: Ed Morley <[email protected]>
@edmorley edmorley mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-kimmel-vmw joe-kimmel-vmw joe-kimmel-vmw left review comments

@jabrown85 jabrown85 jabrown85 left review comments

@AidanDelaney AidanDelaney AidanDelaney left review comments

@dzuelke dzuelke dzuelke left review comments

@hone hone hone approved these changes

@jkutner jkutner jkutner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC #0096] Remove stacks from platform spec
8 participants
@natalieparellano @jkutner @hone @dzuelke @AidanDelaney @jabrown85 @joe-kimmel-vmw @hernandanielg