-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification for CNB_STACK_ID
changed when it was deprecated in Platform API 0.12
#396
Comments
edmorley
added a commit
to edmorley/spec
that referenced
this issue
Mar 27, 2024
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Signed-off-by: Ed Morley <[email protected]>
I've opened #397 for this. (We'll also want to backport to the older branches) |
edmorley
changed the title
Specifcation for
Specification for Mar 27, 2024
CNB_STACK_ID
changed when it was deprecated in Platform API 0.12CNB_STACK_ID
changed when it was deprecated in Platform API 0.12
edmorley
added a commit
to edmorley/spec
that referenced
this issue
Mar 27, 2024
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <[email protected]>
edmorley
added a commit
to edmorley/spec
that referenced
this issue
Mar 27, 2024
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <[email protected]>
edmorley
added a commit
to edmorley/spec
that referenced
this issue
Mar 27, 2024
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <[email protected]>
edmorley
added a commit
to edmorley/spec
that referenced
this issue
Mar 27, 2024
Restores the specification for `CNB_STACK_ID` to the definition that was used prior to the docs refactor in buildpacks#335. Fixes buildpacks#396. Backport of buildpacks#397. Signed-off-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Platform API 0.11 says:
(https://github.com/buildpacks/spec/blob/platform/v0.11/platform.md#build-image)
Under "run image" there is no mention of
CNB_STACK_ID
- ie: the env var only needs to be set in the build image.However, when stacks were deprecated in Platform API 0.12, and the spec updated in #335, the specification was changed to say the
CNB_STACK_ID
env var should be set for both the run and build image:(https://github.com/buildpacks/spec/blob/platform/v0.12/platform.md#iobuildpacksstack-labels)
I'm presuming this change was inadvertent?
The text was updated successfully, but these errors were encountered: