Merge pull request #145 from buildkite/pie-977-prevent-the-ruby-colle…

…ctor-from-raising

Suppress errors when connecting to Buildkite

lib/buildkite/test_collector.rb

@@ -101,5 +101,12 @@ def self.enable_tracing!
         Buildkite::TestCollector::Uploader.tracer&.backfill(:sql, finish - start, **{ query: payload[:sql] })
       end
     end
+
+    def self.safe(&block)
+      block.call
+    rescue StandardError => e
+      logger.error("Buildkite::TestCollector received exception: #{e}")
+      logger.error("Backtrace:\n#{e.backtrace.join("\n")}")
+    end
   end
 end

lib/buildkite/test_collector/library_hooks/minitest.rb

@@ -12,4 +12,4 @@ class Minitest::Test
 
 Buildkite::TestCollector.enable_tracing!
 
-Buildkite::TestCollector::Uploader.configure
+Buildkite::TestCollector.safe { Buildkite::TestCollector::Uploader.configure }

lib/buildkite/test_collector/library_hooks/rspec.rb

@@ -12,7 +12,7 @@
   config.before(:suite) do
     config.add_formatter Buildkite::TestCollector::RSpecPlugin::Reporter
 
-    Buildkite::TestCollector::Uploader.configure
+    Buildkite::TestCollector.safe { Buildkite::TestCollector::Uploader.configure }
   end
 
   config.around(:each) do |example|

spec/test_collector_spec.rb

@@ -24,4 +24,27 @@
       expect(analytics.url).to eq "https://analytics-api.buildkite.com/v1/uploads"
     end
   end
+
+  describe ".safe" do
+    let(:logger) { TestLogger.new }
+
+    class TestLogger
+      attr_reader :errors
+
+      def initialize
+        @errors = []
+      end
+
+      def error(message)
+        @errors << message
+      end
+    end
+
+    before { Buildkite::TestCollector.logger = logger }
+
+    it "suppresses exceptions and logs them to logger.error" do
+      expect{ described_class.safe { raise "penguines dance" } }.to_not raise_error
+      expect(logger.errors.first).to eq("Buildkite::TestCollector received exception: penguines dance")
+    end
+  end
 end