Log backtrace

buildkite · Jul 29, 2022 · 538d26a · 538d26a
1 parent 0cdec78
commit 538d26a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/buildkite/test_collector.rb b/lib/buildkite/test_collector.rb
@@ -106,6 +106,7 @@ def self.safe(&block)
       block.call
     rescue StandardError => e
       logger.error("Buildkite::TestCollector received exception: #{e}")
+      logger.error("Backtrace:\n#{e.backtrace.join("\n")}")
     end
   end
 end
diff --git a/spec/test_collector_spec.rb b/spec/test_collector_spec.rb
@@ -44,7 +44,7 @@ def error(message)
 
     it "suppresses exceptions and logs them to logger.error" do
       expect{ described_class.safe { raise "penguines dance" } }.to_not raise_error
-      expect(logger.errors).to eq(["Buildkite::TestCollector received exception: penguines dance"])
+      expect(logger.errors.first).to eq("Buildkite::TestCollector received exception: penguines dance")
     end
   end
 end