-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-raw-key #262
base: horizon
Are you sure you want to change the base?
on-raw-key #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this go along with a well-formed check that you only use either on-key or on-raw-key but not both?
src/web/js/trove/world.js
Outdated
runtime.getField(Reactors, "raw-key").app( | ||
e.key, | ||
e.type, | ||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this false mean?
src/web/js/trove/world.js
Outdated
|
||
return rawJsworld.on_raw_key( | ||
function(w, e, success) { | ||
console.log("the key event: ", e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray?
…R app name up front
- app.json is only read when FIRST CREATED, future deploys do not read it - All values must be strings
Here's an example program that uses this for reference (not using a share link because the review app doesn't currently have Drive doing what I expect). You can run it by copy/pasting into https://pyret-horizon-pr-262.herokuapp.com/editor
|
Where does this PR stand? |
Is there any update on this? |
A prototype of on-raw-key, which gives more control over keydown and keyup events, as well as information about meta keys