Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_ci.yml #36

Closed
wants to merge 1 commit into from
Closed

Update python_ci.yml #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/python_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ jobs:
python_run_scripts:
strategy:
matrix:
version: [3.9, 3.10, 3.11]
runs-on: ubuntu-latest
python: [3.9.12, 3.10.8, 3.11.10]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the bug fix version numbers required here, or is:

Suggested change
python: [3.9.12, 3.10.8, 3.11.10]
python: [3.9, 3.10, 3.11]

sufficient?

runs-on: ubuntu-20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? Was there an error running on ubuntu-latest? (And if so, does it work on ubuntu-22.04, the newest LTS version?)

steps:
- uses: actions/checkout@v3
- name: setup python
- name: setup python ${{ matrix.python }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.version }} # install the python version needed
python-version: ${{ matrix.python }} # install the python version needed
- run: python install --editable ".[dev]"
Loading