Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_ci.yml #36

Closed
wants to merge 1 commit into from
Closed

Update python_ci.yml #36

wants to merge 1 commit into from

Conversation

kmilo9999
Copy link
Collaborator

No description provided.

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Camilo! I have a couple of questions – what was necessary here?

@@ -4,12 +4,12 @@ jobs:
python_run_scripts:
strategy:
matrix:
version: [3.9, 3.10, 3.11]
runs-on: ubuntu-latest
python: [3.9.12, 3.10.8, 3.11.10]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the bug fix version numbers required here, or is:

Suggested change
python: [3.9.12, 3.10.8, 3.11.10]
python: [3.9, 3.10, 3.11]

sufficient?

version: [3.9, 3.10, 3.11]
runs-on: ubuntu-latest
python: [3.9.12, 3.10.8, 3.11.10]
runs-on: ubuntu-20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? Was there an error running on ubuntu-latest? (And if so, does it work on ubuntu-22.04, the newest LTS version?)

@kmilo9999
Copy link
Collaborator Author

@hollandjg @cpaniaguam Im gonna close this PR. It's pointing to a wrong branch.

@kmilo9999 kmilo9999 closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants