Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 has training resource #39

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

katiestahl
Copy link
Contributor

close #38
add new slot for has_training_resource

@katiestahl katiestahl added the enhancement New feature or request label Nov 18, 2024
@katiestahl katiestahl self-assigned this Nov 18, 2024
@katiestahl
Copy link
Contributor Author

katiestahl commented Nov 18, 2024

@caufieldjh I have no idea what happened here but there are a loooot of changes I wasn't anticipating after running make all. Did I do something wrong? I'm not sure why a bunch of whitespace was changed, and some unused imports were automatically added to standards_schema_all.py 😭 Is this expected? If not, how else should I regenerate the files necessary to go along with this PR?

The actual changes I made are here: 6173b28

@caufieldjh
Copy link
Contributor

Thanks! Looks good!

@caufieldjh
Copy link
Contributor

Those are all expected changes. Most of them are autogenerated, and the unused imports are just a result of the way LinkML templates python classes. Should only cause issues if a linter is configured to run on them, and I don't think it is in this repo.
Most of the generated updates are to the docs and there's some redundancy here because they're getting copied to /docs from the /project directory, but nothing harmful there.

@caufieldjh caufieldjh merged commit a953d18 into main Nov 18, 2024
2 checks passed
@caufieldjh caufieldjh deleted the issue-38-has-training-resource branch November 18, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add slot for has_training_resource
2 participants