Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add tests for PHP 8.4 #30

Merged
merged 2 commits into from
Oct 4, 2024
Merged

chore: Add tests for PHP 8.4 #30

merged 2 commits into from
Oct 4, 2024

Conversation

Chris53897
Copy link

No description provided.

@Chris53897 Chris53897 mentioned this pull request Sep 26, 2024
Merged
@bresam
Copy link
Owner

bresam commented Oct 1, 2024

@Chris53897 thank you also for this PR.
On re-running the pipeline we still get 6 deprecation.
May I ask you to fix these too?

@Chris53897
Copy link
Author

Chris53897 commented Oct 4, 2024 •
edited
Loading

I fixed two of them in https://github.com/bresam/ivory-google-map/pulls

The other 4 are in PHPUnit\Extensions\Selenium2TestCase
It need to be fixed there.
giorgiosironi/phpunit-selenium#460

@bresam bresam merged commit eab0385 into bresam:master Oct 4, 2024
5 of 6 checks passed
@Chris53897 Chris53897 deleted the patch-1 branch October 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bresam bresam Awaiting requested review from bresam bresam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chris53897 @bresam @Chris8934