Merge pull request #30 from Chris53897/patch-1

chore: Add tests for PHP 8.4
bresam · Oct 4, 2024 · eab0385 · eab0385
2 parents 62949e9 + abe740b
commit eab0385
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -35,7 +35,9 @@ jobs:
                   - php: '8.3'
                     symfony-version: 7.0.*
                     stability: prefer-stable
-
+                  - php: '8.4'
+                    symfony-version: 7.0.*
+                    stability: prefer-stable
 
         env:
             APP_ENV: test

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -124,12 +124,12 @@ private function createBusinessAccountNode(bool $service): ArrayNodeDefinition
         return $node;
     }
 
-    private function createNode(string $name = null, string $type = 'array'): ArrayNodeDefinition|NodeDefinition
+    private function createNode(string $name, string $type = 'array'): ArrayNodeDefinition|NodeDefinition
     {
         return $this->createTreeBuilder($name, $type)->getRootNode();
     }
 
-    private function createTreeBuilder(string $name = null, string $type = 'array'): TreeBuilder
+    private function createTreeBuilder(string $name, string $type = 'array'): TreeBuilder
     {
         return new TreeBuilder($name, $type);
     }