This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Tensorflow as optional dependency? #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move check for optional dependency here - Create function decorator to wrap around tensorflow-dependent fns Create a dummy "tf" name in the tensorflow_handle file. This enables us to "from tensorflow_handle import tf" wherever we might need tensorflow, and use the decorator to prevent function execution _before_ we reach the tf name.
11 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
This resolves the tensorflow problem as listed on this BrainGlobe repository issue.
Worth looking at the alternative solution proposed there too.
What does this PR do?
Makes
tensorflowan optional dependency and include-guards alltensorflow-functionality thatcellfinder-coreuses in the event that the user does not havetensorflowinstalled.(Although having examined this, it looks like this means that
cellfinder-coresimply doesn't have any functionality to offer).References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Is this a breaking change?
Yes - users now need to ensure they have
tensorflowpre-installed in their environment, or explicitly request it to be fetched along withcellfinder-corewhen they install.Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: