Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analysis functionality to brainglobe-utils #76

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

adamltyson
Copy link
Member

Part of #73 and requires brainglobe/brainglobe-utils#24 (tests will fail until this is merged & released)

@adamltyson adamltyson marked this pull request as ready for review January 8, 2024 17:08
@adamltyson adamltyson marked this pull request as draft January 8, 2024 17:09
@adamltyson adamltyson marked this pull request as ready for review January 8, 2024 17:20
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ffee651) 82.75% compared to head (c8e8eca) 85.01%.

Files Patch % Lines
...rainglobe_workflows/brainmapper/analyse/analyse.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   82.75%   85.01%   +2.26%     
==========================================
  Files          27       26       -1     
  Lines        1577     1448     -129     
==========================================
- Hits         1305     1231      -74     
+ Misses        272      217      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson requested a review from a team January 11, 2024 17:17
@alessandrofelder alessandrofelder merged commit 2b19243 into main Jan 12, 2024
9 of 10 checks passed
@alessandrofelder alessandrofelder deleted the move-brainglobe-utils-2 branch January 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants