Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Extend Coroutine Documentation #1288

Merged
merged 1 commit into from
Oct 17, 2024
Merged

doc: Extend Coroutine Documentation #1288

merged 1 commit into from
Oct 17, 2024

Conversation

Ashthetik
Copy link
Contributor

This PR extends the written documentation of coroutines to include a note regarding potential error fall-through situations such as #1222

Documentation change checklist

  • My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

@Ashthetik
Include note regarding brainboxdotcc#1222
ab6949b 
Extends the current coroutine intro to include a generalised warning regarding error fall throughs
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit ab6949b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6710b9225f4a1f00081ac824
😎 Deploy Preview https://deploy-preview-1288--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jaskowicz1
Jaskowicz1 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for including a reference for people to go off

Mishura4
Mishura4 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@Mishura4 Mishura4 merged commit fb2b9d9 into brainboxdotcc:dev Oct 17, 2024
13 checks passed
@Jaskowicz1 Jaskowicz1 mentioned this pull request Oct 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaskowicz1 Jaskowicz1 Jaskowicz1 approved these changes

@Mishura4 Mishura4 Mishura4 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashthetik @CLAassistant @Mishura4 @Jaskowicz1