-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coroutines Hiding Errors Within on_ready Event #1222
Comments
Not a bug - you need to print the error yourself with coroutines With that said we could document this better |
Noted. Never knew coroutines would break the logic flow I had. The more you know 👍 |
Is it all good to close this, or should I keep it open for tracking purposes for a docs update? I'd love to PR it, but I suck at formal documentation, lol |
Feel free to PR it! We can always say if something needs to be described more. Besides, some pages in our docs aren't too formal anyways (look at this page for example). |
Updated the labels to reflect @Mishura4 's comment as this isn't a bug but rather a lack of documentation. |
Any news on this? |
is there actually anything to do here? not sure anything needs to be added? |
Documentation |
Yeah I was supposed to make a PR for the docs on this but forgot |
Extends the current coroutine intro to include a generalised warning regarding error fall throughs
All good to close this now with the doc update being merged? Or are we keeping it up for visibility? |
Closed as of #1288 |
Git Commit Reference
ced36fd
Describe the bug:
When utilising coroutines within the
on_ready
function, it's possible for D++ to ignore HTTP error codes and skip on printing any errors.This specifically happens when a user creates a malformed Slash Command (see below) and proceeds to send it to Discord.
To Reproduce:
Utilising the basic layout of the example bot provided in the Using Slash Commands and Interactions wiki:
on_ready
to a coroutine utilisng-> dpp::task<void>
.Expected Behaviour:
As expected with a synchronous command creation, it would also be expected that any error codes would also mirror through with a coroutine setup.
Screenshots:
System Details:
Additional Context:
Example Minimal Code:
The text was updated successfully, but these errors were encountered: