-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implementing named commands handlers for the cluster #1262
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Moved to draft, please don't write text below checklist, just replace the [ please outline ] box with that (along with a desc)! |
looks good to me but far too much random formatting changes all over cluster.h that makes it hard to read. |
Checked it with c++20 and it works in both scenarios of regular and coroutine based handlers. also removing handler while it gets executed also works as supposed |
c++17 also work fine for me Note: all the tests were done on WSL ubuntu 20.04 using clang++19 |
note, this PR is not done yet as we found issues with function semantics |
This is working solution. Tested on both c++17 dpp builds and c++20 WSL ubuntu 20:04 clang++-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just one minor thing
[ Please outline your change here. Be sure to check the checkboxes below. ]
Code change checklist
at this point it is draft pr to get feedback. i hope to test it tomorrow.