Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implementing named commands handlers for the cluster #1262

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

ruslan-ilesik
Copy link
Contributor

@ruslan-ilesik ruslan-ilesik commented Oct 7, 2024

[ Please outline your change here. Be sure to check the checkboxes below. ]

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

at this point it is draft pr to get feedback. i hope to test it tomorrow.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 95270f5
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6705bb7dc775150008e6e3b6
😎 Deploy Preview https://deploy-preview-1262--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 7, 2024
@Jaskowicz1 Jaskowicz1 marked this pull request as draft October 8, 2024 00:25
@Jaskowicz1
Copy link
Contributor

Moved to draft, please don't write text below checklist, just replace the [ please outline ] box with that (along with a desc)!

@braindigitalis
Copy link
Contributor

looks good to me but far too much random formatting changes all over cluster.h that makes it hard to read.
how well does the new feature work?

@ruslan-ilesik
Copy link
Contributor Author

Checked it with c++20 and it works in both scenarios of regular and coroutine based handlers. also removing handler while it gets executed also works as supposed

@ruslan-ilesik
Copy link
Contributor Author

c++17 also work fine for me

Note: all the tests were done on WSL ubuntu 20.04 using clang++19

include/dpp/cluster.h Outdated Show resolved Hide resolved
@ruslan-ilesik
Copy link
Contributor Author

note, this PR is not done yet as we found issues with function semantics

@ruslan-ilesik
Copy link
Contributor Author

This is working solution. Tested on both c++17 dpp builds and c++20

WSL ubuntu 20:04 clang++-19

src/dpp/cluster.cpp Outdated Show resolved Hide resolved
src/dpp/cluster.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis added the hacktoberfest-accepted Issues tagged for hacktoberfest label Oct 8, 2024
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just one minor thing

include/dpp/cluster.h Outdated Show resolved Hide resolved
src/dpp/cluster.cpp Outdated Show resolved Hide resolved
@braindigitalis braindigitalis merged commit 190adf2 into brainboxdotcc:dev Oct 9, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation hacktoberfest-accepted Issues tagged for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants