Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deprecation): officially deprecate commandhandler #1263

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

braindigitalis
Copy link
Contributor

This officially deprecates dpp::commandhandler. This PR should be merged after or alongside #1262.

Schedule for removal is undefined, there are many bots still using this, and removing it entirely would break too much stuff, but deprecating it allows us to wash our hands of it, stop updating it, and refuse to support it directly.

This also closes #1199 as obsolete

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 09c530b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/670534e7f26f3c00099aa396
😎 Deploy Preview https://deploy-preview-1263--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 8, 2024
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely yes.

@braindigitalis braindigitalis merged commit 270381e into dev Oct 9, 2024
54 checks passed
@braindigitalis braindigitalis deleted the deprecate-sync branch October 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants