feat: commandhandler now has functions to edit/get/delete responses #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
documentation
braindigitalis
requested changes
Jul 16, 2024
| thinking(source, ephemeral, callback); | ||
| } | ||
|
|
||
| void commandhandler::edit_response(const message &m, command_source source, command_completion_event_t callback) { |
There was a problem hiding this comment.
these all need a check like in thinking, e.g.:
if (!source.command_token.empty() && source.command_id) {they cant do anything if its a message command.
| }); | ||
| } | ||
|
|
||
| void commandhandler::edit_original_response(const message &m, command_source source, command_completion_event_t callback) { |
There was a problem hiding this comment.
if we're adding these, shouldnt they also work for message commands?
this is the point of commandhandler, and why we dont really add much to it
|
any movement on this? |
5 tasks
|
Closing, we are officially deprecating command handler so we should not support new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions to
dpp::commandhandlerto allow users to edit, get, and delete, responses. Whilstdpp::commandhandleris deprecated, we still have a good few people using it.Code change checklist