Remove outline module from default modules in Viewer

[misiekhardcore]

relates to #2135

Proposed Changes

We don't want to include outline module by default in Viewer modules to not include any visueal, non core functionalities

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[nikku]

Consider whether or not to add a test for this.

[misiekhardcore]

I would love to add a test for this. I just don't know whats the proper place for it
I added one, I think it is failing because Select still depends on it (the changes to diagram-js are not done yet, but locally with linked local diagram-js it was working.
I'm not sure what is the right way of going with this? We need to merge the changes to diagram-js first but they would still have to be released so we can bump the version in this repo?

[nikku]

I'm not sure what is the right way of going with this? We need to merge the changes to diagram-js first but they would still have to be released so we can bump the version in this repo?

For changes that require upstream fix it is fine to prepare + test locally (linked) if things work. We release our libraries continuously, so the next step is to get things merged in diagram-js, release them, and incorporate them into this PR.

[nikku]

Suggested change

	var outline = viewer.get('outline',false);
	var outline = viewer.get('outline', false);

[nikku]

Good test, clearly managing the expectations!

[misiekhardcore]

to make sure I understood correctly - we keep this PR open, fix diagram-js and then update this PR with new diagram-js version so it passes CI?

[nikku]

[...] we keep this PR open, fix diagram-js and then update this PR with new diagram-js version so it passes CI?

Exactly.

[misiekhardcore]

This is now cleaned up and waits for diagram-js version bump to incorporate changes done in bpmn-io/diagram-js#943