Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing diagram-js stylesheet to examples #297

Closed

Conversation

misiekhardcore
Copy link

@misiekhardcore misiekhardcore commented Oct 29, 2024

related to bpmn-io/bpmn-js#2135

Proposed Changes

There were missing diagram-js.css imports missing in some of the examples, which caused for example no indication of selected items and in case of multi-selection - the selected elements were covered by a black rectangle (see the related issue for a GIF)

To try out the solution, simply open any example which and see that selected elements are properly indicated

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku
Copy link
Member

nikku commented Oct 30, 2024

As we discussed we'll not go this route, right @misiekhardcore? Instead we want to fix the issue at the core, ensure that the viewer does not ship with anything that requires external styles.

@misiekhardcore
Copy link
Author

Yes, instead of doing this, we go for solving the root cause. This PR was opened to do so

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 30, 2024
@misiekhardcore misiekhardcore deleted the 2135-multi-selection-in-viewer-causes-black-boxes branch October 30, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants