twoliter: Dedup cargo make logic #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpullen
force-pushed
the
cargo-make
branch
3 times, most recently
from
d81edc6 to
9f928d2
Compare
|
^ Add testing for all |
webern
reviewed
Oct 9, 2023
Comment on lines
+33
to
+65
| let (sdk, toolchain) = require_sdk(project, &arch.into())?; | ||
| Ok(Self::default() | ||
| .env("TLPRIVATE_SDK_IMAGE", sdk) | ||
| .env("TLPRIVATE_TOOLCHAIN", toolchain)) |
There was a problem hiding this comment.
I'm thinking about whether we should just hang on to &'a Project and do things like this during the exec call. I'm also slightly concerned about lack of clarity regarding what args could be passed during exec and which are managed by this object.
These are not huge concerns. Just some things to consider and change if it feels like we can do better.
ecpullen
force-pushed
the
cargo-make
branch
2 times, most recently
from
735e75a to
0eb0330
Compare
webern
approved these changes
Oct 10, 2023
bcressey
approved these changes
Oct 11, 2023
webern
suggested changes
Oct 11, 2023
webern
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Part of the work on #82
Description of changes:
We will be calling cargo make from different CLI commands, so we want the cargo make invocation to be re-usable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.