Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Unused CargoMake functions #104

Closed
webern opened this issue Oct 10, 2023 · 0 comments · Fixed by #108
Closed

Cleanup Unused CargoMake functions #104

webern opened this issue Oct 10, 2023 · 0 comments · Fixed by #108
Assignees

Comments

@webern
Copy link
Contributor

webern commented Oct 10, 2023

          Acknowledging that you copied this from me... we should remove unused functions (unless you are sure you are going to use them later). 

This one feels unnecessary either way since it is easy enough to pass Vec::new(), or [] when you have no args. Also see below, I think IntoIter<Item = String> might work without the type annotation.

Originally posted by @webern in #97 (comment)

Definition of done:

When the CargoMake object does not have unused functions and does not need underscore prefixes to silence warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants