twoliter: drop PATH override for debuginfo #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find-debuginfo` overrides $PATH to prefer its own directory, so this wasn't working as expected. Drop this workaround to avoid conflating host and target tools, which can mask build logic errors in package specs. Signed-off-by: Ben Cressey <[email protected]>
This was referenced Oct 2, 2024
yeazelm
approved these changes
Oct 2, 2024
cbgbt
approved these changes
Oct 3, 2024
arnaldo2792
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket-sdk#210
Description of changes:
find-debuginfooverrides $PATH to prefer its own directory, so this wasn't working as expected.Drop this workaround to avoid conflating host and target tools, which can mask build logic errors in package specs.
Testing done:
Built the core kit on both host architectures, for both target architectures, after taking the SDK change. No
objcopyfailures were logged.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.