macros, build: override find-debuginfo location #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This fixes a regression where
find-debuginfo
now prefersobjcopy
in/usr/bin
rather than the target-specific symlink placed ahead of it in $PATH. That happens becausefind-debuginfo
now adds its own parent directory to $PATH in front of everything else.Work around this by adding a
find-debuginfo
symlink to the debug helper directory, and override the macro so thatfind-debuginfo
is called from that directory.Also add a
readelf
symlink, sincefind-debuginfo
calls it too.Testing done:
Before, the output logs would show errors like this when building on
x86_64
foraarch64
:After, the errors go away since the target-specific
objcopy
is being used.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.