Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify cargo-deny version in INSTALL.md #631

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Specify cargo-deny version in INSTALL.md #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ We also use [cargo-deny](https://github.com/EmbarkStudios/cargo-deny) during the
To get these, run:

```
cargo install cargo-make cargo-deny
cargo install cargo-make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider specifying a version for cargo-make as with cargo-deny, we already pin to versions in the build as "known working". We have even discussed listing out all external dependencies at the versions we know to work and that we use for builds.

That said, I think we can make a judgement call here in saying that we would expect cargo-make to "in general" work for building with (handwave) as we've not experienced any major breaking changes when bumping to a later version of cargo-make ourselves.

A related note: I recently tested with a more recent cargo-make than is pinned in the container: 0.25.1, that pin needs to be updated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward without pinning to a version until we have to. cargo-deny is a special case here, and hopefully will be fixed soon, after which we will remove the version from it also.

cargo install cargo-deny --version 0.2.6
```

#### Docker
Expand Down