Specify cargo-deny version in INSTALL.md #631
Conversation
|
cross-referencing #531 |
| @@ -18,7 +18,8 @@ We also use [cargo-deny](https://github.com/EmbarkStudios/cargo-deny) during the | |||
| To get these, run: | |||
|
|
|||
| ``` | |||
| cargo install cargo-make cargo-deny | |||
| cargo install cargo-make | |||
There was a problem hiding this comment.
I think we should consider specifying a version for cargo-make as with cargo-deny, we already pin to versions in the build as "known working". We have even discussed listing out all external dependencies at the versions we know to work and that we use for builds.
That said, I think we can make a judgement call here in saying that we would expect cargo-make to "in general" work for building with (handwave) as we've not experienced any major breaking changes when bumping to a later version of cargo-make ourselves.
A related note: I recently tested with a more recent cargo-make than is pinned in the container: 0.25.1, that pin needs to be updated!
There was a problem hiding this comment.
Let's move forward without pinning to a version until we have to. cargo-deny is a special case here, and hopefully will be fixed soon, after which we will remove the version from it also.
Issue #, if available:
N/A
Description of changes:
Specify the version of
cargo-denythat needs to be installed to make everything work. Trying tocargo make worldwith the latest version ofcargo-denyfrom crates.io doesn't work.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.