Create a common builder container #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaynes
reviewed
Dec 31, 2019
jhaynes
reviewed
Dec 31, 2019
I agree! I've moved things around in the latest commits along with an update to the README that's there. I'll update the Dockerfile to add some context in comments, I'll circle back with this next year. |
jahkeup
force-pushed
the
builder-container
branch
from
cd867cf
to
6523041
Compare
jahkeup
force-pushed
the
builder-container
branch
from
6523041
to
376ff46
Compare
zmrow
reviewed
Jan 7, 2020
jahkeup
force-pushed
the
builder-container
branch
from
cc4aac1
to
4711571
Compare
|
@zmrow added some comments and took the opportunity to expand some of the conditionals to help explain the flow in the changed scripts. |
Additional tools are required to run the AMI building stage and are common enough to merit being installed by default - eg: aws cli.
This uses the commands provided in the build environment instead of performing the on-demand installation for building within.
jahkeup
force-pushed
the
builder-container
branch
from
4711571
to
5b96f43
Compare
|
Rebased onto latest develop and changing merge target to a "feature" branch to prepare in parts for switching to the containerized environments. |
jahkeup
force-pushed
the
builder-container
branch
from
5b96f43
to
5a39288
Compare
This was referenced Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#592 #541
Description of changes:
This change brings in a Dockerfile for a common base container - a build environment - for use in codebuild for most, if not all, stages that are needed at this time. Related environment improvements were wired in with the changes to the container's "entrypoint" (quoted because this is actually overridden and fully controlled by the CodeBuild service agent).
The use of a common image doesn't significantly reduce the build time from what I can see in my build history with this particular set of changes, but I think this may be due to the options provided to Docker (which causes it to use the less performant
vfsbackend). I'll check to see if usingoverlay2in the CodeBuild task gets us some improvement there.Until the CodeBuild projects and buildspecs are updated this image will not be used without further intervention. I've included a change to the
thar-pr-buildCodeBuild buildspec to show what these will look like. If folks are happy with the changes, I can tie in changes to the other buildspecs as well.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.