tough: Genericize file transport #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iliana destroyer of worlds <[email protected]>
This allows users of tough to add additional functionality when making requests, such as authenticating requests or adding additional HTTP headers. Signed-off-by: iliana destroyer of worlds <[email protected]>
tjkirch
reviewed
Nov 7, 2019
Signed-off-by: iliana destroyer of worlds <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
iliana
force-pushed
the
tough-generic-transport
branch
from
016be1a
to
558487e
Compare
tjkirch
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
This makes the file transport for tough generic, instead of only using a combination of
std::fs::File::openandreqwest::Client::getdepending on the URL scheme.This enables us to override the transport in updog to add host status telemetry for monitoring how updates are actually going (we'd create something similar to tough's new
impl Transport for reqwest::Clientbut we'd add query parameters to the end of the URL).updog works:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.