tough: Merge in tough_schema #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that reqwest is an optional dependency of tough, there is no particular benefit to keeping these crates separate. This just moves tough_schema into tough::schema, without any cleanup. Signed-off-by: iliana destroyer of worlds <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
jahkeup
approved these changes
Nov 8, 2019
| @@ -30,7 +30,6 @@ sha2 = "0.8.0" | |||
| snafu = { version = "0.5.0", features = ["backtrace-crate"] } | |||
| structopt = "0.3" | |||
| tempfile = "3.1.0" | |||
| tough_schema = { path = "../updater/tough_schema" } | |||
etungsten
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges tough_schema back into tough as a module instead of as a separate crate.
The primary reason for splitting them out was for tuftool (and other utilities) to not have to include an HTTP client in their dependency set.
reqwestis now an optional dependency for tough since #488. tough's default dependency tree was then a subset of tough_schema, so this reason no longer holds.Less crates to publish to crates.io is always nice. :)
Hosts in my cluster are now running this code and updog operates as expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.