sources: add empty file to placate twoliter #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
approved these changes
Dec 12, 2024
|
before the force push, CI was failing with So it looks like there's more hackiness going on with |
cbgbt
approved these changes
Dec 12, 2024
jmt-lab
force-pushed
the
develop
branch
4 times, most recently
from
2887eec to
bd6d597
Compare
bcressey
reviewed
Dec 12, 2024
sources/deny.toml
Outdated
Comment on lines
57
to
59
| allow-git = [ | ||
| # The settings SDK is currently provided as a git dependency, | ||
| # We will allow it as an exception until the following is resolved: | ||
| # https://github.com/bottlerocket-os/bottlerocket-settings-sdk/issues/18 | ||
| "https://github.com/bottlerocket-os/bottlerocket-settings-sdk", | ||
| ] |
There was a problem hiding this comment.
Do we need this for some reason?
There was a problem hiding this comment.
ah no i'll clean it up
Comment on lines
+1
to
+2
| This is a temporary workaround for twoliter who currently expects a sources | ||
| directory to exist in order for the docker volume mounts to work in buildkit |
There was a problem hiding this comment.
Is there a backlog issue in Twoliter to avoid needing this?
There was a problem hiding this comment.
I'll be adding it, we had a regression on a bug fix I did.
bcressey
approved these changes
Dec 12, 2024
rpkelly
approved these changes
Dec 12, 2024
rpkelly
pushed a commit
to rpkelly/bottlerocket-kernel-kit
that referenced
this pull request
Dec 20, 2024
sources: add empty file to placate twoliter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add empty sources folder
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.