Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources: switch to empty cargo workspace #8

Closed

Conversation

ginglis13
Copy link
Contributor

Issue number:

Closes #7

Description of changes:

Switch from a fake package in sources/ to an empty Cargo workspace. The fake package was added in #4 to appease the build system, which without a sources/ dir complains:

this may be fixable by adding sources to the workspace.members array of the manifest located at: /home/fedora/kernel-kit/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the workspace.exclude array, or add an empty [workspace] table to the package's manifest.

#4 added a fake package and added it to the top level workspace's exclude array; this PR takes the other option.
This has resolved issues faced in #7

Testing done:

make

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ginglis13 ginglis13 force-pushed the empty-sources-workspace branch from e8c6c87 to 60bd0d4 Compare December 18, 2024 02:27
@ginglis13 ginglis13 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make on fresh clone of kernel-kit results in error parsing project Cargo.toml
1 participant