Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance DPU Tools with Better Minicom Handling, Connectivity Checks, and Runtime Access Improvements #26

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Enhance DPU Tools with Better Minicom Handling, Connectivity Checks, and Runtime Access Improvements #26

merged 5 commits into from
Oct 30, 2024

Commits on Oct 29, 2024

  1. minicom.py: Add clean up to minicom 

    For this tool to be used both as a non-containerized and containerized
environments, we should make it easy to clean up the function by
deferring a clean up action. In go we have the `defer` keyword that
would do this but a way to do it in python is to make
`configure_minicom` a context manager and call it using the `with`
keyword
    @SamD2021
    SamD2021 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    196757a View commit details
    Browse the repository at this point in the history

  2. Dockerfile: Add ping to the container 

    Centos stream9 doesn't seem to ship `ping` in its base image, so we add
it by installing `iputils` to the Dockerfile.
    @SamD2021
    SamD2021 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    39ab2d5 View commit details
    Browse the repository at this point in the history

  3. common_ipu.py: Add check_connectivity function 

    We should have a simple way to check connectivity to a dpu by pinging
its address. This function could be used in the IPU Runtime Access step
to not to attempt running minicom if it already can stablish a
connection with the dpu therefore avoiding cases where the runtime
access has already been granted which minicom may not know how to handle
properly.
    @SamD2021
    SamD2021 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d0e5b9c View commit details
    Browse the repository at this point in the history

  4. common_ipu.py: Fix minicom_get_version 

    When we use minicom to get the version of the firmware for the imc, it
looks for some keywords that aren't shared by all the versions, causing
exceptions to occur.
    @SamD2021
    SamD2021 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    10c24a3 View commit details
    Browse the repository at this point in the history

  5. fwutils.py: Change Simplify Behavior of IPU Runtime Access step 

    We should avoid minicom as much as possible as it can be hard to predict
all the edge cases needed to successfully perform what we have in mind.
In the IPU Runtime Access step it would mean we should first check if it
can connect to it properly, then if not, try the more "manual" method.
    @SamD2021
    SamD2021 committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a2bbdc9 View commit details
    Browse the repository at this point in the history