Enhance DPU Tools with Better Minicom Handling, Connectivity Checks, and Runtime Access Improvements #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SamD2021
commented
Oct 29, 2024
SamD2021
commented
- Added a context manager to minicom.py to manage Minicom configurations cleanly, improving usage in non-containerized environments.
- Updated the Dockerfile to include ping support, enabling connectivity checks within the container.
- Implemented a simple connectivity check function in common_ipu.py to verify IPU reachability before attempting Minicom access.
- Enhanced fwutils.py to reduce unnecessary Minicom usage, optimizing runtime access by checking connectivity first.
- Fixed keyword matching in minicom_get_version for broader firmware compatibility.
For this tool to be used both as a non-containerized and containerized environments, we should make it easy to clean up the function by deferring a clean up action. In go we have the `defer` keyword that would do this but a way to do it in python is to make `configure_minicom` a context manager and call it using the `with` keyword
Centos stream9 doesn't seem to ship `ping` in its base image, so we add it by installing `iputils` to the Dockerfile.
We should have a simple way to check connectivity to a dpu by pinging its address. This function could be used in the IPU Runtime Access step to not to attempt running minicom if it already can stablish a connection with the dpu therefore avoiding cases where the runtime access has already been granted which minicom may not know how to handle properly.
When we use minicom to get the version of the firmware for the imc, it looks for some keywords that aren't shared by all the versions, causing exceptions to occur.
We should avoid minicom as much as possible as it can be hard to predict all the edge cases needed to successfully perform what we have in mind. In the IPU Runtime Access step it would mean we should first check if it can connect to it properly, then if not, try the more "manual" method.
SamD2021
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.