[th/flake8] add flake8 support (with .flake8 config, github action and fix warnings)
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thom311
commented
Aug 27, 2024
thom311
commented
- all: cleanup imports
- requirements: add requirements.txt file with pip modules
- flake8: fix various flake8 warnings
- flake8: add ".flake8" configuration file
- sort imports - by name - imports from stdlib and pip modules first - "import" before "from x import" - wrap lienes so that each import line only imports one name.
./dpu-tools/dpu-tools:61:9: F841 local variable device is assigned to but never used ./dpu-tools/dpu-tools:62:9: F841 local variable function is assigned to but never used ./pxeboot:513:22: C400 Unnecessary generator - rewrite as a list comprehension. ./reset:20:5: F841 local variable bf_pci is assigned to but never used
We need to this at least suppress E203. E203 is about whitespace formatting and conflicts with python-black. Black is the formatter that we use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.