Merge pull request #23 from thom311/th/flake8

[th/flake8] add flake8 support (with `.flake8` config, github action and fix warnings)

.flake8

@@ -0,0 +1,21 @@
+[flake8]
+extend-ignore =
+    E203
+    E501
+    W291
+extend-exclude =
+    *venv*/
+filename =
+    *.py
+    */bfb
+    */console
+    */cx_fwup
+    */dpu-tools/dpu-tools
+    */fwdefaults
+    */fwup
+    */fwversion
+    */get_mode
+    */listbf
+    */pxeboot
+    */reset
+    */set_mode

.github/workflows/lint-test.yml

@@ -19,7 +19,13 @@ jobs:
       run: |
         python -m pip install --upgrade pip
         python -m pip install black
+        python -m pip install flake8
+        python -m pip install -r requirements.txt
     - name: Check code formatting with Black
       run: |
        black --version
        black --check --diff .
+    - name: flake8
+      run: |
+       flake8 --version
+       flake8

bfb

@@ -1,10 +1,11 @@
 #!/usr/bin/env python3
 
-import common_bf
 import argparse
 import requests
 import time
 
+import common_bf
+
 
 def main():
     parser = argparse.ArgumentParser(

common_bf.py

@@ -1,8 +1,9 @@
-from collections import namedtuple
-import subprocess
 import os
-import sys
 import shlex
+import subprocess
+import sys
+
+from collections import namedtuple
 
 
 def run(cmd: str, env: dict = os.environ.copy()):

console

@@ -1,8 +1,9 @@
 #!/usr/bin/env python3
 
+import argparse
 import os
+
 import common_bf
-import argparse
 
 
 def main():

cx_fwup

@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
-import os, sys
+import os
+import sys
 
 
 def main():

dpu-tools/dpu-tools

@@ -1,13 +1,14 @@
 #!/usr/bin/env python3
 
-import os
 import argparse
-import tempfile
-import shutil
+import os
+import re
 import shlex
-from collections import namedtuple
+import shutil
 import subprocess
-import re
+import tempfile
+
+from collections import namedtuple
 
 
 def run(cmd: str, env: dict = os.environ.copy()):
@@ -57,9 +58,6 @@ def find_bus_pci_address(address: str) -> str:
 
     if match:
         bus = match.group(1)
-        device = match.group(2)
-        function = match.group(3)
-
         new_address = f"{bus}:00.0"
         return new_address
     else:

fwdefaults

@@ -1,8 +1,9 @@
 #!/usr/bin/env python3
 
-import os, sys
-import common_bf
 import argparse
+import os
+
+import common_bf
 
 
 def main():

fwup

@@ -1,9 +1,10 @@
 #!/usr/bin/env python3
 
-import sys
+import argparse
 import requests
+import sys
+
 import common_bf
-import argparse
 
 
 class RemoteAPI:

fwversion

@@ -1,8 +1,9 @@
 #!/usr/bin/env python3
 
-import common_bf
 import argparse
 
+import common_bf
+
 
 def main():
     parser = argparse.ArgumentParser(description="Shows firmware version.")

get_mode

@@ -1,7 +1,9 @@
 #!/usr/bin/env python3
-import common_bf
+
 import argparse
 
+import common_bf
+
 
 def main():
     parser = argparse.ArgumentParser(description="Reads the current mode of the BF.")

listbf

@@ -1,4 +1,5 @@
 #!/usr/bin/env python3
+
 import common_bf
 
 

pxeboot

@@ -1,18 +1,21 @@
 #!/usr/bin/env python3
+
 import argparse
+import http.server
+import io
 import os
+import paramiko
+import pexpect
+import requests
+import shutil
 import signal
 import sys
-from multiprocessing import Process
 import threading
-import pexpect
-import paramiko
 import time
-import io
+
+from multiprocessing import Process
+
 import common_bf
-import shutil
-import http.server
-import requests
 
 
 install_entry = "Install OS"
@@ -507,7 +510,7 @@ def try_pxy_boot():
 
     ping_exception = None
     try:
-        candidates = list(f"172.31.100.{x}" for x in range(10, 21))
+        candidates = [f"172.31.100.{x}" for x in range(10, 21)]
         response_ip = wait_any_ping(candidates, 180)
         print(f"got response from {response_ip}")
     except Exception as e:

requirements.txt

@@ -0,0 +1,6 @@
+bcrypt
+paramiko>=2.12.0
+pyasn1
+pynacl
+requests
+setuptools-rust

reset

@@ -1,8 +1,9 @@
 #!/usr/bin/env python3
 
-import common_bf
 import argparse
 
+import common_bf
+
 
 def main():
     parser = argparse.ArgumentParser(description="Reboots the BF.")
@@ -16,7 +17,7 @@ def main():
         help="Specify the id of the BF.",
     )
     args = parser.parse_args()
-    bf_pci = common_bf.find_bf_pci_addresses_or_quit(args.id)
+    common_bf.find_bf_pci_addresses_or_quit(args.id)
     with open(f"/dev/rshim{args.id//2}/misc", "w") as f:
         f.write("SW_RESET 1")
 

set_mode

@@ -1,7 +1,9 @@
 #!/usr/bin/env python3
-import common_bf
-import os
+
 import argparse
+import os
+
+import common_bf
 
 
 def main():