Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify appending to env var JAVACMD_OPTIONS #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify appending to env var JAVACMD_OPTIONS #96

wants to merge 2 commits into from

Commits on Mar 13, 2018

  1. Simplify appending to env var JAVACMD_OPTIONS 

    In default Bash, it is not an error to refer to an undeclared (or empty)
variable. In that case, it will just expand to an empty string.

So there's no need to do the prior check, you can just append the new value
right away.

Also, in Bash you can safely set and export on the same command.
    @aureliojargas
    aureliojargas committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    6d52951 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. Avoid errors when in "-o nounset" mode 

    PR bmwcarit#90 will add "-o unset" to this file, so we need this variable expansion to
guard when the $JAVACMD_OPTIONS is unset.
    @aureliojargas
    aureliojargas committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7be6d89 View commit details
    Browse the repository at this point in the history