Simplify appending to env var JAVACMD_OPTIONS #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In default Bash, it is not an error to refer to an undeclared (or empty) variable. In that case, it will just expand to an empty string. So there's no need to do the prior check, you can just append the new value right away. Also, in Bash you can safely set and export on the same command.
|
Thanks. I love the conciseness of this! PR #90 adds |
|
@jongiddy thanks for the heads-up! In that case, the Since it will also work even when |
PR bmwcarit#90 will add "-o unset" to this file, so we need this variable expansion to guard when the $JAVACMD_OPTIONS is unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In default Bash, it is not an error to refer to an undeclared (or empty) variable. In that case, it will just expand to an empty string.
So there's no need to do the prior check, you can just append the new value right away.
Also, in Bash you can safely set and export on the same command.