Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize the feed switcher with the feed drag gesture #1696

Closed
wants to merge 15 commits into from
Closed

Synchronize the feed switcher with the feed drag gesture #1696

wants to merge 15 commits into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 13, 2023 •
edited
Loading

WIP.

  • Scroll the feed switcher on drag
  • Interpolate the indicator to current item
  • Interpolate color
  • Fix flicker
  • Fix jump on drag + tap
  • Fix no selection on initial render
  • Revert to a simpler model, this is too complicated and doesn't work
  • Fix web
  • What's up with that right margin
  • What should happen if number of feeds changes (relayout, adjust scroll, etc)
  • Types, naming, etc

@mozzius mozzius mentioned this pull request Nov 24, 2024
Closed
This was referenced Nov 26, 2024
Merged
Merged
@gaearon
Copy link
Collaborator Author

gaearon commented Dec 1, 2024

implemented in #6868

@gaearon gaearon closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaearon