Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate tab indicator #4524

Closed
wants to merge 2 commits into from
Closed

Animate tab indicator #4524

wants to merge 2 commits into from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Jun 14, 2024

Screen.Recording.2024-06-14.at.21.19.12.mov

Copy link

render bot commented Jun 14, 2024

Copy link

github-actions bot commented Jun 14, 2024

Old size New size Diff
7.42 MB 7.43 MB 1.12 KB (0.01%)

@mozzius mozzius closed this Jun 14, 2024
@AronBe
Copy link

AronBe commented Nov 24, 2024

Hi, I was thinking about adding animation to the indicator. Was there a reason this got closed? Would you like me to revisit this?

@mozzius
Copy link
Member Author

mozzius commented Nov 24, 2024

Dan has a better PR that actually syncs it with the swipe gesture

#1696

However, perf is terrible on android. If you can figure out how to make perf not terrible, that'd be great!

@AronBe
Copy link

AronBe commented Nov 30, 2024

Hey, had a busy week at work, but got it working today 💪 will create a PR tomorrow 👍

@gaearon
Copy link
Contributor

gaearon commented Nov 30, 2024

@AronBe, sorry I didn't see this thread — I've already done the work in #6868. Happy to look over your implementation though in case there's something I can improve.

@AronBe
Copy link

AronBe commented Nov 30, 2024

Sure, will tag you tomorrow 👍

@AronBe
Copy link

AronBe commented Nov 30, 2024

created my PR at the end :) #6873

I reviewed your approach @gaearon, you found the right one, similar to mine, so end result will be the same, good job! You can take inspiration from mine to add animated indicator to web as well, it is just one extra useEffect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants