Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Undefined behavior regression #141

Merged
merged 3 commits into from
Feb 23, 2024
Merged

bug: Undefined behavior regression #141

merged 3 commits into from
Feb 23, 2024

Commits on Feb 22, 2024

  1. bug: Undefined behavior regression

    Previously we had allowed strings to be sent via `note-c` without a newline-terminator.
    Subsequently, we decided this was undefined behavior that should not be supported.
    This caused a regression in downstream testing, and we have restored the original
    behavior (although undefined by the Notecard communication specification).
    zfields committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    085449b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. bug: fix memory access

    Allocated string did NOT have a NULL-terminator required by `strstr`.
    Fake Function Framework (FFF) does not make copies of strings for testing mocks,
    so it was instead accessing released memory which was triggering valgrind errors.
    zfields committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    20d921b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f686aea View commit details
    Browse the repository at this point in the history